Discussion:
[PATCH] x86: Add APU3 reference to x86 board.d
(too old to reply)
Kristian Evensen
2018-03-15 12:30:27 UTC
Permalink
There is a new APU-model available, APU3. The device is configured in
the same way as the APU1 and APU2, so the same LED/network setup can be
used.

I considered changing the case to pc-engines-apu*, but I chose to follow
the existing pattern and add the full board name.

Signed-off-by: Kristian Evensen <***@gmail.com>
---
target/linux/x86/base-files/etc/board.d/01_leds | 2 +-
target/linux/x86/base-files/etc/board.d/02_network | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/linux/x86/base-files/etc/board.d/01_leds b/target/linux/x86/base-files/etc/board.d/01_leds
index 04e11705ac..25dc4aeeb1 100755
--- a/target/linux/x86/base-files/etc/board.d/01_leds
+++ b/target/linux/x86/base-files/etc/board.d/01_leds
@@ -8,7 +8,7 @@
board_config_update

case "$(board_name)" in
-pc-engines-apu|pc-engines-apu2)
+pc-engines-apu|pc-engines-apu2|pc-engines-apu3)
ucidef_set_led_netdev "wan" "WAN" "apu2:green:led3" "eth0"
ucidef_set_led_netdev "lan" "LAN" "apu2:green:led2" "br-lan"
ucidef_set_led_default "diag" "DIAG" "apu2:green:power" "1"
diff --git a/target/linux/x86/base-files/etc/board.d/02_network b/target/linux/x86/base-files/etc/board.d/02_network
index bea696d8ff..c6e381b946 100755
--- a/target/linux/x86/base-files/etc/board.d/02_network
+++ b/target/linux/x86/base-files/etc/board.d/02_network
@@ -9,7 +9,7 @@
board_config_update

case "$(board_name)" in
-pc-engines-apu|pc-engines-apu2)
+pc-engines-apu|pc-engines-apu2|pc-engines-apu3)
ucidef_set_interfaces_lan_wan "eth1 eth2" "eth0"
;;
traverse-technologies-geos)
--
2.14.1
Kristian Evensen
2018-04-18 09:40:35 UTC
Permalink
On Thu, Mar 15, 2018 at 1:30 PM, Kristian Evensen
Post by Kristian Evensen
There is a new APU-model available, APU3. The device is configured in
the same way as the APU1 and APU2, so the same LED/network setup can be
used.
I considered changing the case to pc-engines-apu*, but I chose to follow
the existing pattern and add the full board name.
Ping on this patch :) Perhaps it should have been sent to lede-dev instead?

-Kristian
Philip Prindeville
2018-04-21 00:58:55 UTC
Permalink
Looks okay to me.

Are the cases stenciled with the port #’s?

Last PC Engines board I had (a Alix 2D3) the firmware would detect the ports in the opposite order (PCI enumerator) than the markings on the case.
Post by Kristian Evensen
There is a new APU-model available, APU3. The device is configured in
the same way as the APU1 and APU2, so the same LED/network setup can be
used.
I considered changing the case to pc-engines-apu*, but I chose to follow
the existing pattern and add the full board name.
---
target/linux/x86/base-files/etc/board.d/01_leds | 2 +-
target/linux/x86/base-files/etc/board.d/02_network | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/linux/x86/base-files/etc/board.d/01_leds b/target/linux/x86/base-files/etc/board.d/01_leds
index 04e11705ac..25dc4aeeb1 100755
--- a/target/linux/x86/base-files/etc/board.d/01_leds
+++ b/target/linux/x86/base-files/etc/board.d/01_leds
@@ -8,7 +8,7 @@
board_config_update
case "$(board_name)" in
-pc-engines-apu|pc-engines-apu2)
+pc-engines-apu|pc-engines-apu2|pc-engines-apu3)
ucidef_set_led_netdev "wan" "WAN" "apu2:green:led3" "eth0"
ucidef_set_led_netdev "lan" "LAN" "apu2:green:led2" "br-lan"
ucidef_set_led_default "diag" "DIAG" "apu2:green:power" "1"
diff --git a/target/linux/x86/base-files/etc/board.d/02_network b/target/linux/x86/base-files/etc/board.d/02_network
index bea696d8ff..c6e381b946 100755
--- a/target/linux/x86/base-files/etc/board.d/02_network
+++ b/target/linux/x86/base-files/etc/board.d/02_network
@@ -9,7 +9,7 @@
board_config_update
case "$(board_name)" in
-pc-engines-apu|pc-engines-apu2)
+pc-engines-apu|pc-engines-apu2|pc-engines-apu3)
ucidef_set_interfaces_lan_wan "eth1 eth2" "eth0"
;;
traverse-technologies-geos)
Kristian Evensen
2018-04-21 08:17:37 UTC
Permalink
Hi,

On Sat, Apr 21, 2018 at 2:58 AM, Philip Prindeville
Post by Philip Prindeville
Looks okay to me.
Great!
Post by Philip Prindeville
Are the cases stenciled with the port #’s?
No, there are no markings on the case.

-Kristian
Lars Kruse
2018-04-22 22:16:47 UTC
Permalink
Hi,


Am Sat, 21 Apr 2018 10:17:37 +0200
Post by Kristian Evensen
Post by Philip Prindeville
Are the cases stenciled with the port #’s?
No, there are no markings on the case.
just in case, that this detail is of any interest: the PCB contains labels for
the three ethernet ports:
Loading Image...
(from: http://pcengines.ch/apu3a2.htm)

Cheers,
Lars

Loading...