Discussion:
[PATCH] ARM: dts: Set DNS-313 LEDs to use better triggers
(too old to reply)
Linus Walleij
2018-03-20 03:07:45 UTC
Permalink
We just used one LED for "disk activity" but using the green
LED for disk read and the red LED for disk write gives a way
better user experience.

Signed-off-by: Linus Walleij <***@linaro.org>
---
The necessary changes to the LED trigger has been merged to the
LEDs subsystem.
---
arch/arm/boot/dts/gemini-dlink-dns-313.dts | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
index da8bb9d60f99..5fb3ea8bf300 100644
--- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts
+++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
@@ -59,14 +59,13 @@
label = "dns313:green:disk";
gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>;
default-state = "off";
- linux,default-trigger = "ide-disk";
- /* Ideally should activate while reading */
+ linux,default-trigger = "disk-read";
};
led-disk-red {
label = "dns313:red:disk";
gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
default-state = "off";
- /* Ideally should activate while writing */
+ linux,default-trigger = "disk-write";
};
};
--
2.14.3
Loading...