[OpenWrt-Devel] [PATCH] add a option in menuconfig to set a custom folder for the images & packages -- fix typo, sorry for this

[Oliver Ertl]

Signed-off-by: Oliver Ertl <***@ertls-netzwerk.de>
---
rules.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules.mk b/rules.mk
index 2d4d5c8..8594ca6 100644
--- a/rules.mk
+++ b/rules.mk
@@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI
endif

DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl)
-DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD))
+BIN_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD))
INCLUDE_DIR:=$(TOPDIR)/include
SCRIPT_DIR:=$(TOPDIR)/scripts
BUILD_DIR_BASE:=$(TOPDIR)/build_dir

[Hartmut Knaack]

Now I see. IMHO sending a [PATCH V2] would be the cleaner solution.

Post by Oliver Ertl
---
rules.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules.mk b/rules.mk
index 2d4d5c8..8594ca6 100644
--- a/rules.mk
+++ b/rules.mk
@@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI
endif
DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl)
-DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD))
+BIN_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD))
INCLUDE_DIR:=$(TOPDIR)/include
SCRIPT_DIR:=$(TOPDIR)/scripts
BUILD_DIR_BASE:=$(TOPDIR)/build_dir

[Michael Heimpold]

Hi,

Post by Hartmut Knaack
Now I see. IMHO sending a [PATCH V2] would be the cleaner solution.

+1

Post by Hartmut Knaack

Post by Oliver Ertl
---
rules.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules.mk b/rules.mk
index 2d4d5c8..8594ca6 100644
--- a/rules.mk
+++ b/rules.mk
@@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI
endif
DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl)
-DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD))

I guess this is still wrong or should both patches be applied in order?
Then this should be a series, please resubmit.

BTW: could you explain your intension a little bit in the commit message? I wondering
what a use case of this patch would be...

Post by Hartmut Knaack

Post by Oliver Ertl
+BIN_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD))
INCLUDE_DIR:=$(TOPDIR)/include
SCRIPT_DIR:=$(TOPDIR)/scripts
BUILD_DIR_BASE:=$(TOPDIR)/build_dir

_______________________________________________
openwrt-devel mailing list
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[Oliver Ertl]

Yes, you are right. Next time :-)


Von Samsung Mobile gesendet

-------- UrsprÃŒngliche Nachricht --------
Von: Hartmut Knaack <***@gmx.de>
Datum:
An: OpenWrt Development List <openwrt-***@lists.openwrt.org>
Betreff: Re: [OpenWrt-Devel] [PATCH] add a option in menuconfig to set a custom folder for the images & packages -- fix typo, sorry for this

Now I see. IMHO sending a [PATCH V2] would be the cleaner solution.

---
  rules.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules.mk b/rules.mk
index 2d4d5c8..8594ca6 100644
--- a/rules.mk
+++ b/rules.mk
@@ -80,7 +80,7 @@ ifdef CONFIG_MIPS64_ABI
  endif
 
  DL_DIR:=$(if $(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(call qstrip,$(CONFIG_DOWNLOAD_FOLDER)),$(TOPDIR)/dl)
-DL_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD))
+BIN_DIR:=$(if $(call qstrip,$(CONFIG_BINARY_FOLDER)),$(call qstrip,$(CONFIG_BINARY_FOLDER)),$(TOPDIR)/bin/$(BOARD))
  INCLUDE_DIR:=$(TOPDIR)/include
  SCRIPT_DIR:=$(TOPDIR)/scripts
  BUILD_DIR_BASE:=$(TOPDIR)/build_dir